-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute the WordLift Vector Store #13028
Conversation
…wordlift-vector-store
…2107-add-support-for-the-wordlift-vector-store
…' of github.com:wordlift/llama_index into feature/12107-add-support-for-the-wordlift-vector-store
…2107-add-support-for-the-wordlift-vector-store
…-wordlift-vector-store Feature/12107 add support for the wordlift vector store
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…feature/12107-add-support-for-the-wordlift-vector-store
@ziodave Seems like the tests aren't working. Have you tried running them locally? |
@logan-markewich yes, sorry I converted the PR to draft until we fix it. May I ask, we recreated the ubuntu-latest-unit-tester in our organization GH Runners so that we can have the GH Actions run on our fork, https://github.com/wordlift/llama_index/actions/runs/8800952266. Oddly enough the tests pass there, is there a special configuration we need to apply to the GH Runner? This is basically the configuration we did: |
@ziodave I don't think any special config is needed. The errors in the test seem unrelated to env though
|
@logan-markewich we're on it, we'll update the PR soon. Thanks! |
@logan-markewich we're ready for review 🙏 |
…2107-add-support-for-the-wordlift-vector-store-resync
…eature/12107-add-support-for-the-wordlift-vector-store-resync
…-resync' of https://github.com/wordlift/llama_index into feature/12107-add-support-for-the-wordlift-vector-store-resync
…-wordlift-vector-store-resync Feature/12107 add support for the wordlift vector store resync
Reopening after fixing the issues. Local tests succeed. We need to check here too. |
We're checking the Python 3.10 test. |
@logan-markewich we fixed the tests. Please let us know if you need more actions from our side. Cheers. |
I think this looks good now. My remaining concern is just around the ID and metadata stuff |
@logan-markewich I fixed the |
Description
Add support for the WordLift Vector Store.
Fixes #12107
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
How Has This Been Tested?
Suggested Checklist:
make format; make lint
to appease the lint gods